[Asterisk-code-review] res_musiconhold: Don't crash when real-time doesn't return any entries (asterisk[16])

Sean Bright asteriskteam at digium.com
Tue Dec 15 08:07:28 CST 2020


Attention is currently required from: Nathan Bruning.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15212 )

Change subject: res_musiconhold: Don't crash when real-time doesn't return any entries
......................................................................


Patch Set 2:

(2 comments)

File res/res_musiconhold.c:

https://gerrit.asterisk.org/c/asterisk/+/15212/comment/6271d90b_547d4fb8 
PS1, Line 1616: 			// entries is NULL if there are no results
> Change to /* C-style comments */ or drop entirely.
Done


https://gerrit.asterisk.org/c/asterisk/+/15212/comment/80641bc5_566dd312 
PS1, Line 1617: 			if (entries != NULL) {
> This can just be (but you can ignore this if you like): […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15212
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ifbf0a4f786ab2a52342f9d1a1db4c9907f069877
Gerrit-Change-Number: 15212
Gerrit-PatchSet: 2
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Attention: Nathan Bruning <nathan at iperity.com>
Gerrit-Comment-Date: Tue, 15 Dec 2020 14:07:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201215/cc3233a5/attachment.html>


More information about the asterisk-code-review mailing list