[Asterisk-code-review] res_pjsip_nat.c: Create deep copies of strings when appropriate (asterisk[16])

nappsoft asteriskteam at digium.com
Mon Dec 14 09:21:42 CST 2020


Attention is currently required from: George Joseph.
nappsoft has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15209 )

Change subject: res_pjsip_nat.c: Create deep copies of strings when appropriate
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> Have you submitted the pjproject patch upstream?  If so, have they accepted it?
Actually Ralf Kubis had submitted a proposal (what can be seen in the linked issue) and based on his feedback they implemented a slightly different patch. The patch I've included is the one from pjsip upstream: https://github.com/pjsip/pjproject/commit/ce18018cc17bef8f80c08686e3a7b28384ef3ba5



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15209
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic5acd7fa2fbda3080f5f36ef12e46804939b198b
Gerrit-Change-Number: 15209
Gerrit-PatchSet: 3
Gerrit-Owner: nappsoft <infos at nappsoft.ch>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 15:21:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201214/98d52369/attachment.html>


More information about the asterisk-code-review mailing list