[Asterisk-code-review] res_ari: Fix wrong media uri handle for channel play (asterisk[master])

sungtae kim asteriskteam at digium.com
Mon Dec 14 03:05:55 CST 2020


Attention is currently required from: Joshua Colp.
sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15205 )

Change subject: res_ari: Fix wrong media uri handle for channel play
......................................................................


Patch Set 2:

(3 comments)

Patchset:

PS2: 
Fixed it. 😊


File res/res_stasis_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/15205/comment/42e3add9_2e188de1 
PS1, Line 492: 		if (media[i] == NULL) {
> That's better. Fixed it. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/15205/comment/6fd9516d_ff45237b 
PS1, Line 493: 			ast_log(LOG_ERROR, "Invalid media uri. The given media is null. channel: %s\n",
> Sure, np. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15205
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6691c640247a51ad15f23e4a203ca8430809bafe
Gerrit-Change-Number: 15205
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 09:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: sungtae kim <pchero21 at gmail.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201214/6d1422e0/attachment.html>


More information about the asterisk-code-review mailing list