[Asterisk-code-review] res_ari: Fix wrong media uri handle for channel play (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15205 )

Change subject: res_ari: Fix wrong media uri handle for channel play
......................................................................


Patch Set 2:

(2 comments)

Hi Joshua,

Thanks for your kind reviewing.
Fixed it as your comments. 😊

https://gerrit.asterisk.org/c/asterisk/+/15205/1/res/res_stasis_playback.c 
File res/res_stasis_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/15205/1/res/res_stasis_playback.c@492 
PS1, Line 492: 		if (media[i] == NULL) {
> Should this use ast_strlen_zero instead?
That's better. Fixed it. 😊


https://gerrit.asterisk.org/c/asterisk/+/15205/1/res/res_stasis_playback.c@493 
PS1, Line 493: 			ast_log(LOG_ERROR, "Invalid media uri. The given media is null. channel: %s\n",
> I think this log message should be adjusted to more closely match other error messages, for example: […]
Sure, np. 😊



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15205
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6691c640247a51ad15f23e4a203ca8430809bafe
Gerrit-Change-Number: 15205
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 09 Dec 2020 02:35:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201208/b4f43eb6/attachment-0001.html>