[Asterisk-code-review] media_cache: Fix reference leak with bucket file metadata (asterisk[18])

Joshua Colp asteriskteam at digium.com
Thu Dec 3 08:44:00 CST 2020


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/15189 )

Change subject: media_cache: Fix reference leak with bucket file metadata
......................................................................

media_cache: Fix reference leak with bucket file metadata

Change-Id: Ia0e4124110df613ce5fdfa9ef8780016ebaa52c6
---
M main/media_cache.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, approved; Approved for Submit
  Kevin Harwell: Looks good to me, but someone else must approve



diff --git a/main/media_cache.c b/main/media_cache.c
index 15f70d0..b303643 100644
--- a/main/media_cache.c
+++ b/main/media_cache.c
@@ -184,6 +184,7 @@
 					}
 					ast_free(mime_type);
 				}
+				ao2_ref(header, -1);
 			}
 		}
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15189
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia0e4124110df613ce5fdfa9ef8780016ebaa52c6
Gerrit-Change-Number: 15189
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201203/a8c92d6d/attachment.html>


More information about the asterisk-code-review mailing list