[Asterisk-code-review] res_pjsip_diversion: implement support for History-Info (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14729 )

Change subject: res_pjsip_diversion: implement support for History-Info
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

Do we have to add "histinfo" to the Supported header somewhere?

https://gerrit.asterisk.org/c/asterisk/+/14729/9//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/14729/9//COMMIT_MSG@1 
PS9, Line 1: Parent:     75756ab8 (res_pjsip_diversion: handle 181)
A little more info would be nice. Maybe reference the RFC?
Add the ASTERISK issue id.


https://gerrit.asterisk.org/c/asterisk/+/14729/9/res/res_pjsip_diversion.c 
File res/res_pjsip_diversion.c:

https://gerrit.asterisk.org/c/asterisk/+/14729/9/res/res_pjsip_diversion.c@172 
PS9, Line 172: 
Need some explanation about these 2 functions.  At first glance, they appear to do the same thing (although they don't) and the function name "get_history_info_header_to" is confusing because the first line in the function says "From".  It took me a while to realize that "get_history_info_header_to" wasn't referencing a "To" header.  Maybe change the names to "get_to_history_info_header" and "get_from_history_info_header"?

Would also be good to explain the concept of how you determine the "to" and "from" headers.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14729
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2296369582d4b295c5ea1e60bec391dd1d318fa6
Gerrit-Change-Number: 14729
Gerrit-PatchSet: 9
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 31 Aug 2020 13:56:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200831/ad9c2c90/attachment-0001.html>