[Asterisk-code-review] res_pjsip_diversion: implement support for History-Info (asterisk[16])

Richard Mudgett asteriskteam at digium.com
Fri Aug 28 08:37:37 CDT 2020


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14729 )

Change subject: res_pjsip_diversion: implement support for History-Info
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14729/8/contrib/ast-db-manage/config/versions/e658c26033ca_create_history_info_flag.py 
File contrib/ast-db-manage/config/versions/e658c26033ca_create_history_info_flag.py:

https://gerrit.asterisk.org/c/asterisk/+/14729/8/contrib/ast-db-manage/config/versions/e658c26033ca_create_history_info_flag.py@1 
PS8, Line 1: """create history info flag
Please use the below boolean define to avoid compatibility issues:

AST_BOOL_NAME = 'ast_bool_values'
# We'll just ignore the n/y and f/t abbreviations as Asterisk does not write
# those aliases.
AST_BOOL_VALUES = [ '0', '1',
                    'off', 'on',
                    'false', 'true',
                    'no', 'yes' ]

You can find usage in other Asterisk alembic scripts.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14729
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2296369582d4b295c5ea1e60bec391dd1d318fa6
Gerrit-Change-Number: 14729
Gerrit-PatchSet: 8
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 28 Aug 2020 13:37:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200828/c17ccd76/attachment.html>


More information about the asterisk-code-review mailing list