[Asterisk-code-review] sip_nat_settings: Update script for latest Linux. (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14831 )

Change subject: sip_nat_settings: Update script for latest Linux.
......................................................................


Patch Set 3:

> can't actually reach ipv4.icanhazip.com

Although solved via the DNS method, I am curious about this: Any idea why you cannot reach that Webpage? Is that in general (even via a browser on that machine) or was it only via this script?

> so you'll need to use a timeout

‘So’ means ‘as consequence’, right? Again, I am curious because I do not understand that consequence. If you cannot reach that Webpage, you cannot get the external IP. Then, the remainder of that script is useless. Were you about to use wget/fetch/curl consistently within the Asterisk project, align it with what is done in the third-party directory: <https://github.com/asterisk/asterisk/commit/d3f070c7a26a79e1f02a745288c5b66e41324146>?

I have seen a lot of timeout complains in <https://community.asterisk.org>. However, I have not checked if they silenced after
<https://github.com/asterisk/asterisk/commit/12dde3b568ff3e44527b73f61b073f902edfb10f>
Anyway, are you stating that rather than hanging the script, failing a script is better?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14831
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I9b1a7c3f457e3553b50a3e9a55524e40d70245a0
Gerrit-Change-Number: 14831
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 28 Aug 2020 10:23:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200828/acb4dfdd/attachment.html>