[Asterisk-code-review] sip_nat_settings: Update script for latest Linux. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14831 )

Change subject: sip_nat_settings: Update script for latest Linux.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14831/2/contrib/scripts/sip_nat_settings 
File contrib/scripts/sip_nat_settings:

https://gerrit.asterisk.org/c/asterisk/+/14831/2/contrib/scripts/sip_nat_settings@37 
PS2, Line 37: 	externip=`${WGET} -q -O- http://ipv4.icanhazip.com`
I can't actually reach ipv4.icanhazip.com (but I can for ipv6) so you'll need to use a timeout and set retries to 1.
"wget -q -T 5 -t 1 -O- http://ipv4.icanhazip.com".

I'd also add curl as an option and make sure curl and fetch have timeouts as well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14831
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I9b1a7c3f457e3553b50a3e9a55524e40d70245a0
Gerrit-Change-Number: 14831
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 27 Aug 2020 14:56:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200827/5f3201ab/attachment.html>