[Asterisk-code-review] app_voicemail: ensure strings are not NULL/empty before using (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14810 )

Change subject: app_voicemail: ensure strings are not NULL/empty before using
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14810/1//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/14810/1//COMMIT_MSG@9 
PS1, Line 9: The handle_subscribe function was not checking the passed in strings for
           : NULL in all cases. This patch now checks and makes sure those strings are
           : not NULL/empty before being used.
> I don't see how mailbox or context could have been NULL or empty. […]
In 'mwi_sub_event_cb' the strings are duped before being passed in. Those duplicates are not checked for NULL.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14810
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I61da04fe2c2bee0a02480f43301203f31de511c0
Gerrit-Change-Number: 14810
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 26 Aug 2020 16:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200826/a51d36ab/attachment.html>