[Asterisk-code-review] res_pjsip_session: Handle multi-stream re-invites better (asterisk[certified/16.8])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14730 )

Change subject: res_pjsip_session:  Handle multi-stream re-invites better
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/14730/3/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/14730/3/res/res_pjsip_session.c@2265 
PS3, Line 2265: Droped
s/Droped/Dropped


https://gerrit.asterisk.org/c/asterisk/+/14730/3/res/res_pjsip_session.c@5265 
PS3, Line 5265: 	} \
If a test fails do we want to continue with the rest of the tests?


https://gerrit.asterisk.org/c/asterisk/+/14730/3/res/res_pjsip_session.c@5295 
PS3, Line 5295: 	test_media_add(delayed_active_state, "audio", AST_MEDIA_TYPE_AUDIO, AST_STREAM_STATE_SENDRECV, -1);
I assume no need to check the 'test_media_add' result? If NULL is returned then CHECKER will fail later?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14730
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: Id3440972943c611a15f652c6c569fa0e4536bfcb
Gerrit-Change-Number: 14730
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 23:13:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200825/12ef987e/attachment-0001.html>