[Asterisk-code-review] res_pjsip_diversion: handle 181 (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14764 )

Change subject: res_pjsip_diversion: handle 181
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14764/2/res/res_pjsip_diversion.c 
File res/res_pjsip_diversion.c:

https://gerrit.asterisk.org/c/asterisk/+/14764/2/res/res_pjsip_diversion.c@262 
PS2, Line 262: 	/* Only send indication if it was due to a response */
This comment is inaccurate. This queues up a redirecting update, it doesn't itself send an indication.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14764
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I73cfee46a8ca85371280ebdb38674f8fde7510df
Gerrit-Change-Number: 14764
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Torrey Searle <tsearle at gmail.com>
Gerrit-Comment-Date: Mon, 24 Aug 2020 12:51:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200824/bee5e82b/attachment.html>