[Asterisk-code-review] bridge_channel: Ensure text messages are zero terminated (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14736 )

Change subject: bridge_channel: Ensure text messages are zero terminated
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14736/1/main/bridge_channel.c 
File main/bridge_channel.c:

https://gerrit.asterisk.org/c/asterisk/+/14736/1/main/bridge_channel.c@2367 
PS1, Line 2367: 		ast_debug(1, "Sending TEXT frame to '%s': %*.s\n",
              : 				ast_channel_name(bridge_channel->chan),
              : 				fr->datalen, (char *) fr->data.ptr);
> Should be better to move ast_debug inside 'if (txt)'. […]
I thought about that, but I think in the event of OOM I would want the debug to print (assuming it could do so when we were OOM) so I had a better indication of what we were doing when we ran out of memory... I could go either way, so if you feel strongly i can switch it around.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14736
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ic10057387ce30b2094613ea67e3ae8c5c431dda3
Gerrit-Change-Number: 14736
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Wed, 19 Aug 2020 19:27:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200819/a90c7101/attachment.html>