[Asterisk-code-review] followme: allow disabling callee prompt (asterisk[13])

[Dennis]

Dennis has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14696 )

Change subject: followme: allow disabling callee prompt
......................................................................


Patch Set 3:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > > Patch Set 2:
> > > 
> > > (3 comments)
> > > 
> > > > Patch Set 2: Code-Review-2
> > > > 
> > > > This review can't be cleanly cherry-picked to the other branches.  You'll need to cherry-pick to 16 locally and figure out the conflicts.
> > > 
> > > I'm a little confused. You ask to cherry-pick manually but this was already done for 16, 18 and master branches? I also noticed those builds are unstable but I'm not sure what that means... Jenkins shows two failed pjsip tests and one failed AMI connection. I'm not sure how those are related to a chan_sip change? What should I do?
> > 
> > It was unclear that this was a backported change from the other branches. There's no need to worry about those, then.
> 
> Thanks, I just noticed that too. (I got confused because I mixed up app_followme changes with chan_sip changes, sorry). It appears Tzafrir already submitted this change as https://gerrit.asterisk.org/c/asterisk/+/2843/2 but we have something different in our build. This is why this change is colliding with 16 and forwards. Starting to see a pattern here. Trying to decide out whether to backport his change or abandon this change.

Ok, decided to backport Tzafrir's patch. His patch has been merged since Asterisk 14 so there's no need to cherry-pick for 16 and others.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14696
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ic15a2bac4f16d0fce7a1b5e7b375f9bafee37aa4
Gerrit-Change-Number: 14696
Gerrit-PatchSet: 3
Gerrit-Owner: Dennis <dennis.buteyn at xorcom.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Comment-Date: Wed, 19 Aug 2020 11:30:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200819/808cee01/attachment.html>