[Asterisk-code-review] app_voicemail: Fix broken subscription (asterisk[16])

Karsten Wemheuer asteriskteam at digium.com
Sat Aug 15 07:17:44 CDT 2020


Karsten Wemheuer has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/14731 )


Change subject: app_voicemail: Fix broken subscription
......................................................................

app_voicemail: Fix broken subscription

In the function "handle_subscribe" "mailbox" and "context" are stored in
mwi_sub->mailbox as "mailbox at context". The mailbox was overwritten, so that
only the context was saved. This patch restores the old behavior (as in 16.11)

Change-Id: I8be59d175b2b48e4d5b806df5581ac01a01531a3
---
M apps/app_voicemail.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/31/14731/1

diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index ada7382..f50b7b0 100644
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -13371,7 +13371,7 @@
 
 	if (!ast_strlen_zero(p->context)) {
 		strcat(mwi_sub->mailbox, "@");
-		ast_copy_string(mwi_sub->mailbox, p->context, context_len);
+		ast_copy_string(mwi_sub->mailbox + strlen(p->mailbox)+1, p->context, context_len);
 	}
 
 	AST_RWLIST_WRLOCK(&mwi_subs);

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14731
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8be59d175b2b48e4d5b806df5581ac01a01531a3
Gerrit-Change-Number: 14731
Gerrit-PatchSet: 1
Gerrit-Owner: Karsten Wemheuer <kwe-digium at iptam.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200815/ffca3ce3/attachment.html>


More information about the asterisk-code-review mailing list