[Asterisk-code-review] utils.c: NULL terminate ast_base64decode_string. (asterisk[master])
Sean Bright
asteriskteam at digium.com
Tue Aug 4 16:14:41 CDT 2020
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14723 )
Change subject: utils.c: NULL terminate ast_base64decode_string.
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.asterisk.org/c/asterisk/+/14723/1/main/utils.c
File main/utils.c:
https://gerrit.asterisk.org/c/asterisk/+/14723/1/main/utils.c@334
PS1, Line 334: decoded_string = ast_calloc(1, decoded_len + 1);
Very minor & feel free to ignore but a malloc should be sufficient here since you are overwriting everything.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14723
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Icdd7d05b323b0c47ff6ed43492937a03641bdcf5
Gerrit-Change-Number: 14723
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 04 Aug 2020 21:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200804/2fbc0f9c/attachment.html>
More information about the asterisk-code-review
mailing list