[Asterisk-code-review] pjsip: Add timer refactor patch and timer 0 cancellation. (asterisk[certified/16.8])

Joshua Colp asteriskteam at digium.com
Mon Aug 3 04:47:31 CDT 2020


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/14741

to look at the new patch set (#3).

Change subject: pjsip: Add timer refactor patch and timer 0 cancellation.
......................................................................

pjsip: Add timer refactor patch and timer 0 cancellation.

There have been numerous timer issues over the years which
resulted in Teluu doing a major refactor of the timer
implementation whereby the timer entries themselves are not
trusted. This change backports this refactor which has
been shown to resolve timer crashes.

Additionally another patch has been backported to prevent
timer entries with an internal id of 0 from being canceled.
This would result in the invalid timer id of 0 being placed
into the timer heap causing issues. This is also a backport.

Change-Id: I1ba318b1f153a6dd7458846396e2867282b428e7
(cherry picked from commit 9ce6d46aea3a7ec70fe923a58cb2aafaa1ea64a8)
---
A third-party/pjproject/patches/0040-pjsip-timer-refactor.patch
A third-party/pjproject/patches/0041-pjlib_cancel_timer_0.patch
2 files changed, 1,187 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/41/14741/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14741
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: I1ba318b1f153a6dd7458846396e2867282b428e7
Gerrit-Change-Number: 14741
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200803/420053ce/attachment.html>


More information about the asterisk-code-review mailing list