[Asterisk-code-review] res_stir_shaken: Implemented signature verification. (asterisk[master])
Benjamin Keith Ford
asteriskteam at digium.com
Wed Apr 29 12:47:20 CDT 2020
Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14220 )
Change subject: res_stir_shaken: Implemented signature verification.
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.asterisk.org/c/asterisk/+/14220/6/res/res_stir_shaken.c
File res/res_stir_shaken.c:
https://gerrit.asterisk.org/c/asterisk/+/14220/6/res/res_stir_shaken.c@377
PS6, Line 377: set_public_key_expiration(public_key_url, (const struct curl_cb_data *)data);
> Is the explicit cast needed here?
Originally the compiler complained that it was not being passed in as "const", but it appears to be ok with it now.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14220
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3ba4c63880493bf8c7d17a9cfca1af0e934d1a1c
Gerrit-Change-Number: 14220
Gerrit-PatchSet: 6
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 29 Apr 2020 17:47:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200429/dc73e48c/attachment.html>
More information about the asterisk-code-review
mailing list