[Asterisk-code-review] app_queue: track masquerades in app_queue to avoid leaked stasis subs... (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14321 )

Change subject: app_queue: track masquerades in app_queue to avoid leaked stasis subscriptions
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14321/2/main/stasis_channels.c 
File main/stasis_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/14321/2/main/stasis_channels.c@1142 
PS2, Line 1142: static struct ast_json *masquerade_to_json(
              : 	struct stasis_message *message,
              : 	const struct stasis_message_sanitizer *sanitize)
              : {
              : 	return channel_blob_to_json(message, "ChannelMasquerade", sanitize);
              : }
> Hi Joshua, […]
It's not required to implement this, you can still raise an internal Stasis message without this. By implementing the to_json callback you make it available in JSON over ARI, that's what I don't think should exist.

You should just just be able to remove the to_json callback in here and it'll be fine.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14321
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ifc5f9f9fd70903f3c6e49738d3bc632b085d2df6
Gerrit-Change-Number: 14321
Gerrit-PatchSet: 2
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 28 Apr 2020 15:51:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Nathan Bruning <nathan at iperity.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200428/a74345cc/attachment.html>