[Asterisk-code-review] app_fax: SpanDSP headers do not use ast_malloc; ignore that. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Fri Apr 24 05:18:33 CDT 2020


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/14280 )

Change subject: app_fax: SpanDSP headers do not use ast_malloc; ignore that.
......................................................................

app_fax: SpanDSP headers do not use ast_malloc; ignore that.

Since Asterisk 14, app_fax did not compile at all because Asterisk
requires that not malloc but ast_malloc is used everywhere. However,
the system headers of SpanDSP use malloc. Because we cannot (and do
not need to) change system headers, let us ignore this.

ASTERISK-28848

Change-Id: I31f7a6b92a07032c5cef1c16b8901b107fe35546
---
M apps/app_fax.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, approved; Approved for Submit
  George Joseph: Looks good to me, but someone else must approve



diff --git a/apps/app_fax.c b/apps/app_fax.c
index c5d0f51..d9b0a35 100644
--- a/apps/app_fax.c
+++ b/apps/app_fax.c
@@ -20,6 +20,8 @@
 	<replacement>res_fax</replacement>
 ***/
 
+/* Needed for spandsp headers */
+#define ASTMM_LIBC ASTMM_IGNORE
 #include "asterisk.h"
 
 #include <string.h>

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14280
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I31f7a6b92a07032c5cef1c16b8901b107fe35546
Gerrit-Change-Number: 14280
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200424/ce6729db/attachment.html>


More information about the asterisk-code-review mailing list