[Asterisk-code-review] res_stir_shaken: Implemented signature verification. (asterisk[master])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14220 )

Change subject: res_stir_shaken: Implemented signature verification.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14220/4/res/res_stir_shaken.c 
File res/res_stir_shaken.c:

https://gerrit.asterisk.org/c/asterisk/+/14220/4/res/res_stir_shaken.c@395 
PS4, Line 395: snprintf(file_path, sizeof(file_path), "%s", default_path);
             : 
             : 		/* We should have a successful download at this point, so
             : 		 * add an entry to the database.
             : 		 */
             : 		add_public_key_to_astdb(public_key_url, file_path);
> No reason to duplicate the file_path here as you can just pass the default directly to the "add_publ […]
This signals that default_path is being used for a new download. In the block below it, we check to see if the key is expired. If it is and we did not just download it, then we use the same file path that was found in AstDB. If it wasn't, then file_path needs to be default_path.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14220
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3ba4c63880493bf8c7d17a9cfca1af0e934d1a1c
Gerrit-Change-Number: 14220
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 23 Apr 2020 15:21:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200423/b4393a45/attachment-0001.html>