[Asterisk-code-review] stream: Enforce formats immutability and ensure formats exist. (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Wed Apr 22 14:38:13 CDT 2020


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14276 )

Change subject: stream: Enforce formats immutability and ensure formats exist.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14276/1/include/asterisk/stream.h 
File include/asterisk/stream.h:

https://gerrit.asterisk.org/c/asterisk/+/14276/1/include/asterisk/stream.h@167 
PS1, Line 167: const struct ast_format_cap *ast_stream_get_formats(const struct ast_stream *stream);
This breaks the API.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14276
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I32f29715330db4ff48edd6f1f359090458a9bfbe
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 19:38:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200422/6e8965ce/attachment.html>


More information about the asterisk-code-review mailing list