[Asterisk-code-review] res_stir_shaken: Implemented signature verification. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14220 )

Change subject: res_stir_shaken: Implemented signature verification.
......................................................................


Patch Set 3:

> Patch Set 3: Code-Review-1
> 
> (4 comments)
> 
> I'm somewhat confused by the need for astdb.  We assemble the path to the key from ast_config_AST_DATA_DIR, STIR_SHAKEN_DIR_NAME and the URL when we save the key, why can't we do the same to retrieve the key instead of storing it in the astdb?

Explained in IRC:
<bford> gtjoseph: i had a couple of thoughts for that
<bford> 1, if the file happens to be stored somewhere but the default changes, we still retain that info
<bford> 2, if in the future we add a way to store certain certs under certain dirs (or anything organizational), this way the underlying structure is already there and the only thing that needs to be added is where they get stored, rather than the default
<gtjoseph> ok.  makes sense for future work.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14220
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3ba4c63880493bf8c7d17a9cfca1af0e934d1a1c
Gerrit-Change-Number: 14220
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 14:21:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200422/ec0a1d3b/attachment.html>