[Asterisk-code-review] chan_mobile: Add smoother to make SIP/RTP endpoints happy. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14265 )

Change subject: chan_mobile: Add smoother to make SIP/RTP endpoints happy.
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2: Code-Review-1
> > 
> > Unfortunately I had to move this change to the 16 branch itself for possible inclusion, as 16.2 has already been released and changes can not be done against it. As a result this appears to have merge conflicted. Can you update the review so it does not, or do you need assistance?
> 
> Sorry, first time I'm using gerrit workflows. Tried to rebase my submission, which seemed not to cause issues, when pushing to back, strange things happended.
> Maybe give me a hint how to reproduce the merge problem, I will try to fix it asap.

I think in your other attempt your branch was still based off of 16.2 so the change went back up against that. For this change I resolved the issue for you by clicking the "Rebase" button at the top, so that the change was applied to the tip of 16.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14265
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic5f9e2f35868ae59cc9356afbd1388b779a1267f
Gerrit-Change-Number: 14265
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Turczak <peter at turczak.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 17 Apr 2020 11:23:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200417/33862d41/attachment.html>