[Asterisk-code-review] res_pjsip_refer: Sync load- and build-time deps. (asterisk[16])

Alexander Traud asteriskteam at digium.com
Fri Apr 17 06:22:30 CDT 2020


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14256 )

Change subject: res_pjsip_refer: Sync load- and build-time deps.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14256/1/res/res_pjsip_refer.c 
File res/res_pjsip_refer.c:

https://gerrit.asterisk.org/c/asterisk/+/14256/1/res/res_pjsip_refer.c@1259 
PS1, Line 1259: 	.load_pri = AST_MODPRI_APP_DEPEND,
> The REFER process itself creates an implicit pubsub subscription which relies on the pubsub function […]
OK. But then it is not a build/compile/link dependency. Sounds like we can abandon this change then. Or shall I add the dependency to MODULEINFO?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14256
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic693c3f464e35ec0db242afdb0a1415806af4e25
Gerrit-Change-Number: 14256
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 17 Apr 2020 11:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Alexander Traud <pabstraud at compuserve.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200417/5032b4a1/attachment.html>


More information about the asterisk-code-review mailing list