[Asterisk-code-review] taskprocessor.c: add NULL check for tps->listener (asterisk[16])

Joshua Colp asteriskteam at digium.com
Fri Apr 17 05:17:49 CDT 2020


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14214 )

Change subject: taskprocessor.c: add NULL check for tps->listener
......................................................................


Patch Set 1: Code-Review-1

I agree with Richard. Looking at the code the only time this can be NULL is if the taskprocessor has been destroyed or is in the process of being destroyed, which means another crash is likely to occur elsewhere.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14214
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I43f6e09cb6fbe3aa3b596107c9b281ebf42104fa
Gerrit-Change-Number: 14214
Gerrit-PatchSet: 1
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 17 Apr 2020 10:17:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200417/7f5cb7cc/attachment.html>


More information about the asterisk-code-review mailing list