[Asterisk-code-review] res_pjsip: Add build-time dependency. (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14268 )

Change subject: res_pjsip: Add build-time dependency.
......................................................................


Patch Set 1:

This is another, the last class of issues when it comes to res_pjsip_session. These two modules use res_pjsip_session which was identified correctly with code review 7872. However, MODULEINFO got not synchronized back then; actually these two modules never (even in branch 13) ever declared their dependency on res_pjsip_session before. Consequently, thanks to 7872, this issue got revealed.

Looking at all this (different) issues and causes, I really recommend that the core team goes through the whole Asterisk code with the help of IWYU and identify missing headers, build dependencies, and load requirements. I recommended that already two years ago. However, I am going to repeat this now. My fixed ones today are just the tip of the iceberg.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14268
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Icb08304744ae3f34dce6ccb76f94379b8382a074
Gerrit-Change-Number: 14268
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-CC: Friendly Automation
Gerrit-Comment-Date: Fri, 17 Apr 2020 10:04:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200417/a1969e3a/attachment.html>