[Asterisk-code-review] res_pjsip_refer: Sync load- and build-time deps. (asterisk[master])

Alexander Traud asteriskteam at digium.com
Fri Apr 17 04:27:11 CDT 2020


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14266 )

Change subject: res_pjsip_refer: Sync load- and build-time deps.
......................................................................


Patch Set 1:

Caused by <https://gerrit.asterisk.org/7872>
I checked the code and I I did not find any
- import the header of that module
- use of a symbol of that module
I am not sure, why Corey declared it as required back then. Therefore, I propose to remove it. Otherwise, we have to add "res_pjsip_pubsub" as depend in MODULEINFO.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14266
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic693c3f464e35ec0db242afdb0a1415806af4e25
Gerrit-Change-Number: 14266
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-CC: Corey Farrell <git at cfware.com>
Gerrit-CC: Friendly Automation
Gerrit-Comment-Date: Fri, 17 Apr 2020 09:27:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200417/4576c72d/attachment.html>


More information about the asterisk-code-review mailing list