[Asterisk-code-review] codec_gsm: Honor global optimization flags like DONT_OPTIMIZE. (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14262 )

Change subject: codec_gsm: Honor global optimization flags like DONT_OPTIMIZE.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > DONT_OPTIMIZE is already handled correctly.
> 
> No. GSM added OPTIMIZE from the top always. And OPTIMIZE is set always. Consequently, the result was -O0 -O3 even in case of DONT_OPTIMIZE. I fiddled around with GCC to determine what GCC makes out of that but I am still not sure. I guess it was -O3. If you have a better description, please, take over the change. However, it is actually DONT_OPTIMIZE which was not handled correctly.

This is what I see
Without DONT_OPTIMIZE
gcc -o src/add.o -c src/add.c -g3 -O3  -O3 -O3
With DONT_OPTIMIZE
gcc -o src/add.o -c src/add.c -g3 -O0  -O3 -O0   

Now for gcc 4.2 ONLY it would be handled incorrectly but that's not what the commit message states.  If you don't want to update the commit message that's fine but this change won't be accepted as is.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14262
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If65ffcf34045fff1c86a3d492feba222a48f3806
Gerrit-Change-Number: 14262
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 15:34:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200416/8fadefcd/attachment.html>