[Asterisk-code-review] res rtp asterisk.c: Check for first DTMF having timestamp set to 0 (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14141 )

Change subject: res_rtp_asterisk.c: Check for first DTMF having timestamp set to 0
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/14141/3/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/14141/3/res/res_rtp_asterisk.c@4531 
PS3, Line 4531: 			if ((rtp->last_seqno != seqno) && ((timestamp > rtp->last_end_timestamp) || ((timestamp == 0) && (rtp->last_end_timestamp == 0)))) {
> Should be better to declare rtp->last_end_timestamp as int instead of unsigned int and initialize it to -1, instead of 0?

The timestamp in an RTP packet is unsigned, so if last_end_timestamp comes directly from the packet then it cannot be signed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14141
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I3196803a062dd2daee4938c9a778c3810cb7e504
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 3
Gerrit-Owner: Bernard Merindol <bernard.merindol at telnowedge.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 09 Apr 2020 15:52:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200409/2367931e/attachment.html>