[Asterisk-code-review] res rtp asterisk.c: Check for first DTMF having timestamp set to 0 (asterisk[16.9])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14141 )

Change subject: res_rtp_asterisk.c: Check for first DTMF having timestamp set to 0
......................................................................


Patch Set 2: Code-Review-2

Hi Bernard.  Thanks for submitting the review.  I'll be fixing some things up for you that you might want to remember for the next time.

Reviews should always be submitted against the "base" branches (13, 16, 17, master) and never directly to the "release" branches (13.32, 16.9, etc).  They'll get moved automatically to the next release branch when the time comes.

You should always submit your review against the lowest "base" branch to which it applies.  In this case, your review applies to 13 as well as 16, 17 and master.  So you can submit it against 13, then use the Gerrit "cherry-pick" function to copy it to the other branches.  If your review is large or controversial you may want to submit it only to the lowest branch and wait for at least 1 "+1" code review before cherry-picking it to the other branches.  I'm going to cherry-pick this one to 13 only for now.

I've also updated your commit message somewhat.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14141
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16.9
Gerrit-Change-Id: I3196803a062dd2daee4938c9a778c3810cb7e504
Gerrit-Change-Number: 14141
Gerrit-PatchSet: 2
Gerrit-Owner: Bernard Merindol <bernard.merindol at telnowedge.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 08 Apr 2020 14:11:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200408/6db84dd1/attachment.html>