[Asterisk-code-review] chan_unistim: Avoid tautological warnings with clang. (asterisk[master])

[Joshua Colp]

Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/14084 )

Change subject: chan_unistim: Avoid tautological warnings with clang.
......................................................................

chan_unistim: Avoid tautological warnings with clang.

ASTERISK-28803

Change-Id: I15449621b68d0ad4d57b7c337c1167adb15135af
---
M channels/chan_unistim.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  Kevin Harwell: Looks good to me, approved
  George Joseph: Looks good to me, but someone else must approve



diff --git a/channels/chan_unistim.c b/channels/chan_unistim.c
index 0ed190b..99cd2d1 100644
--- a/channels/chan_unistim.c
+++ b/channels/chan_unistim.c
@@ -1351,7 +1351,7 @@
 
 static int is_key_favorite(struct unistim_device *d, int fav)
 {
-	if ((fav < 0) && (fav > 5)) {
+	if ((fav < 0) || (fav >= FAVNUM)) {
 		return 0;
 	}
 	if (d->sline[fav]) {
@@ -1365,7 +1365,7 @@
 
 static int is_key_line(struct unistim_device *d, int fav)
 {
-	if ((fav < 0) && (fav > 5)) {
+	if ((fav < 0) || (fav >= FAVNUM)) {
 		return 0;
 	}
 	if (!d->sline[fav]) {

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14084
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I15449621b68d0ad4d57b7c337c1167adb15135af
Gerrit-Change-Number: 14084
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200408/fa181a0f/attachment.html>