[Asterisk-code-review] test_stasis: Avoid always true warning with clang. (asterisk[master])

Friendly Automation asteriskteam at digium.com
Tue Apr 7 19:04:44 CDT 2020


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/14087 )

Change subject: test_stasis: Avoid always true warning with clang.
......................................................................

test_stasis: Avoid always true warning with clang.

ASTERISK-28808

Change-Id: I5e76831373532d7b8065d024e66cd1fb75dedd80
---
M tests/test_stasis.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved
  George Joseph: Looks good to me, but someone else must approve
  Friendly Automation: Approved for Submit



diff --git a/tests/test_stasis.c b/tests/test_stasis.c
index e620039..08c3d1e 100644
--- a/tests/test_stasis.c
+++ b/tests/test_stasis.c
@@ -2201,7 +2201,7 @@
 		data = stasis_message_data(cts->consumer->messages_rxed[i]);
 		ast_test_status_update(test, "Message type received: %s %s\n",
 			stasis_message_type_name(stasis_message_type(cts->consumer->messages_rxed[i])),
-			data && data->description ? data->description : "no data");
+			data && !ast_strlen_zero(data->description) ? data->description : "no data");
 	}
 }
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14087
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5e76831373532d7b8065d024e66cd1fb75dedd80
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200407/877c31ce/attachment.html>


More information about the asterisk-code-review mailing list