[Asterisk-code-review] res/res_pjsip: Fix for double ipv6 ip bracket quotation (...asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Sep 26 08:58:43 CDT 2019


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12905 )

Change subject: res/res_pjsip: Fix for double ipv6 ip bracket quotation
......................................................................


Patch Set 1: Code-Review-1

I just tested this in the testsuite with the latest 16, as we have coverage for IPv6 inbound. The Contact header of the 200 OK in the test is:

Contact: <sip:[::1]:5060>
Contact: <sip:[::1]:5060;transport=TCP>

Which does not appear to be double quoted on either UDP or TCP. Can you provide further information on the specific scenario that this occurs on the JIRA issue with logs?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12905
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7e3a88d91973378031753b8c1bdc53882fff2921
Gerrit-Change-Number: 12905
Gerrit-PatchSet: 1
Gerrit-Owner: Jørgen H <asterisk.org at hovland.cx>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 26 Sep 2019 13:58:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190926/8e8524a8/attachment.html>


More information about the asterisk-code-review mailing list