[Asterisk-code-review] res/res_pjsip: Fix for double ipv6 ip bracket quotation (...asterisk[16])

Jørgen H asteriskteam at digium.com
Thu Sep 26 08:22:28 CDT 2019


Jørgen H has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/12974


Change subject: res/res_pjsip: Fix for double ipv6 ip bracket quotation
......................................................................

res/res_pjsip: Fix for double ipv6 ip bracket quotation

ASTERISK-28544

Change-Id: I7e3a88d91973378031753b8c1bdc53882fff2921
(cherry picked from commit 89e2dab1c7a261fab195e9f5a2afb19eecb140fd)
---
M res/res_pjsip.c
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/74/12974/1

diff --git a/res/res_pjsip.c b/res/res_pjsip.c
index 7123938..81be270 100644
--- a/res/res_pjsip.c
+++ b/res/res_pjsip.c
@@ -3673,12 +3673,10 @@
 
 	contact.ptr = pj_pool_alloc(rdata->tp_info.pool, PJSIP_MAX_URL_SIZE);
 	contact.slen = pj_ansi_snprintf(contact.ptr, PJSIP_MAX_URL_SIZE,
-			"<%s:%s%.*s%s:%d%s%s>",
+			"<%s:%.*s:%d%s%s>",
 			uas_use_sips_contact(rdata) ? "sips" : "sip",
-			(type & PJSIP_TRANSPORT_IPV6) ? "[" : "",
 			(int)transport->local_name.host.slen,
 			transport->local_name.host.ptr,
-			(type & PJSIP_TRANSPORT_IPV6) ? "]" : "",
 			transport->local_name.port,
 			(type != PJSIP_TRANSPORT_UDP && type != PJSIP_TRANSPORT_UDP6) ? ";transport=" : "",
 			(type != PJSIP_TRANSPORT_UDP && type != PJSIP_TRANSPORT_UDP6) ? pjsip_transport_get_type_name(type) : "");

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12974
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7e3a88d91973378031753b8c1bdc53882fff2921
Gerrit-Change-Number: 12974
Gerrit-PatchSet: 1
Gerrit-Owner: Jørgen H <asterisk.org at hovland.cx>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190926/45da8966/attachment-0001.html>


More information about the asterisk-code-review mailing list