[Asterisk-code-review] res_pjsip_pubsub: add endpoint to some warning (...asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12952 )

Change subject: res_pjsip_pubsub: add endpoint to some warning
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/12952/1/res/res_pjsip_pubsub.c 
File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/#/c/12952/1/res/res_pjsip_pubsub.c@761 
PS1, Line 761: static struct ast_sip_subscription_handler *subscription_get_handler_from_rdata(pjsip_rx_data *rdata)
I'd suggest altering this so the endpoint is passed in, so it can work with both persistence and the normal flow. This will also guarantee the endpoint exists.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12952
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia2811ec226d8a12659b4f9d4d224b48289650827
Gerrit-Change-Number: 12952
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 26 Sep 2019 09:10:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190926/fcf17a8c/attachment.html>