[Asterisk-code-review] taskprocessor.c: Added "like" support to 'core show taskprocessors' (...asterisk[13])

Sean Bright asteriskteam at digium.com
Wed Sep 25 12:39:57 CDT 2019


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12960 )

Change subject: taskprocessor.c: Added "like" support to 'core show taskprocessors'
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/12960/2/main/taskprocessor.c 
File main/taskprocessor.c:

https://gerrit.asterisk.org/#/c/12960/2/main/taskprocessor.c@611 
PS2, Line 611: 			if (!strncasecmp(like, tps->name, strlen(like))) {
The length of 'like' isn't going to change for the life of this function, so you can either pass in the length of assign it to a local variable before the loop.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12960
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I021e740201e9ba487204b5451e46feb0e3222464
Gerrit-Change-Number: 12960
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 25 Sep 2019 17:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190925/bcaa722a/attachment.html>


More information about the asterisk-code-review mailing list