[Asterisk-code-review] res_pjsip_pubsub: change warning to debug (...asterisk[certified/16.3])
George Joseph
asteriskteam at digium.com
Wed Sep 25 06:45:59 CDT 2019
George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/asterisk/+/12949 )
Change subject: res_pjsip_pubsub: change warning to debug
......................................................................
res_pjsip_pubsub: change warning to debug
The following message:
"Subscription request from endpoint <blah> rejected. Expiration of 0 is invalid"
Would sometimes spam the log with warnings if Asterisk restarted and a bunch
of clients sent unsubscribes. This patch changes it from a warning to a debug
message.
Change-Id: I841ec42f65559f3135e037df0e55f89b6447a467
---
M res/res_pjsip_pubsub.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sean Bright: Looks good to me, but someone else must approve
George Joseph: Looks good to me, approved; Approved for Submit
diff --git a/res/res_pjsip_pubsub.c b/res/res_pjsip_pubsub.c
index 394b1ac..075f010 100644
--- a/res/res_pjsip_pubsub.c
+++ b/res/res_pjsip_pubsub.c
@@ -2969,7 +2969,7 @@
expires_header = pjsip_msg_find_hdr(rdata->msg_info.msg, PJSIP_H_EXPIRES, rdata->msg_info.msg->hdr.next);
if (expires_header) {
if (expires_header->ivalue == 0) {
- ast_log(LOG_WARNING, "Subscription request from endpoint %s rejected. Expiration of 0 is invalid\n",
+ ast_debug(1, "Subscription request from endpoint %s rejected. Expiration of 0 is invalid\n",
ast_sorcery_object_get_id(endpoint));
pjsip_endpt_respond_stateless(ast_sip_get_pjsip_endpoint(), rdata, 400, NULL, NULL, NULL);
return PJ_TRUE;
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12949
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: certified/16.3
Gerrit-Change-Id: I841ec42f65559f3135e037df0e55f89b6447a467
Gerrit-Change-Number: 12949
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190925/48002fa8/attachment.html>
More information about the asterisk-code-review
mailing list