[Asterisk-code-review] pjsip mwi replaced_by_unsolicited: Increase timeouts (...testsuite[16])

[Friendly Automation]

Friendly Automation has submitted this change and it was merged. ( https://gerrit.asterisk.org/c/testsuite/+/12934 )

Change subject: pjsip mwi replaced_by_unsolicited: Increase timeouts
......................................................................

pjsip mwi replaced_by_unsolicited: Increase timeouts

On some systems the test timeouts were not high enough, and were causing the
tests to sometimes fail if running slower. This patch increases the timeouts
to give enough time for test conditions to be met on slower running systems.

Change-Id: Iaaf9aa2ae4ad9b850dac90bbe4e0d4f550901940
---
M tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml
M tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml
2 files changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Sean Bright: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml b/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml
index 13a48a9..592aca6 100644
--- a/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml
+++ b/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/aggregate/test-config.yaml
@@ -33,6 +33,7 @@
             typename: 'pluggable_modules.EventActionModule'
 
 sipp-config:
+    reactor-timeout: 40
     test-iterations:
         -
             # Due to the nature of SIPp, and it's handling of out of call messages
@@ -48,9 +49,9 @@
                 # is responsible for gracefully shutting itself down. See the scenario
                 # itself for more information.
                 #
-                # Note, we must tell SIPp to cause an error on scenario timeout (20 seconds).
+                # Note, we must tell SIPp to cause an error on scenario timeout (30 seconds).
                 # This way the test will fail if the expected number of calls is not met.
-                - { 'key-args': {'scenario': 'unsolicited.xml', '-i': '127.0.0.1', '-p': '5062', '-m': '2', '-timeout_error': ''} }
+                - { 'key-args': {'scenario': 'unsolicited.xml', '-i': '127.0.0.1', '-p': '5062', '-m': '2', '-timeout': '30', '-timeout_error': ''} }
                 - { 'key-args': {'scenario': 'solicited.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice'} }
 
 event-action-config:
diff --git a/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml b/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml
index d875013..e430bd0 100644
--- a/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml
+++ b/tests/channels/pjsip/subscriptions/mwi/solicited/replaced_by_unsolicited/non_aggregate/test-config.yaml
@@ -33,6 +33,7 @@
             typename: 'pluggable_modules.EventActionModule'
 
 sipp-config:
+    reactor-timeout: 40
     test-iterations:
         -
             # Due to the nature of SIPp, and it's handling of out of call messages
@@ -48,9 +49,9 @@
                 # is responsible for gracefully shutting itself down. See the scenario
                 # itself for more information.
                 #
-                # Note, we must tell SIPp to cause an error on scenario timeout (20 seconds).
+                # Note, we must tell SIPp to cause an error on scenario timeout (30 seconds).
                 # This way the test will fail if the expected number of calls is not met.
-                - { 'key-args': {'scenario': 'unsolicited.xml', '-i': '127.0.0.1', '-p': '5062', '-m': '3', '-timeout_error': ''} }
+                - { 'key-args': {'scenario': 'unsolicited.xml', '-i': '127.0.0.1', '-p': '5062', '-m': '3', '-timeout': '30', '-timeout_error': ''} }
                 - { 'key-args': {'scenario': 'solicited.xml', '-i': '127.0.0.1', '-p': '5061', '-s': 'alice'} }
 
 event-action-config:

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/12934
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: Iaaf9aa2ae4ad9b850dac90bbe4e0d4f550901940
Gerrit-Change-Number: 12934
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190925/90a6220f/attachment-0001.html>