[Asterisk-code-review] res_pjsip_registrar: Validate Contact URI before adding to responses (...asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12954 )

Change subject: res_pjsip_registrar: Validate Contact URI before adding to responses
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Additionally, we should probably validate the contact URIs are valid at configuration time. That is made a touch more difficult because we don't have easy access to a memory pool in res_pjsip/location.c.

If I recall we used to do that, but because you need to dispatch to a PJSIP thread it was possible in some circumstances to cause a deadlock. Explanation at https://gerrit.asterisk.org/c/asterisk/+/1469


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12954
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Id2b643e58b975bc560aab1c111e6669d54db9102
Gerrit-Change-Number: 12954
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 24 Sep 2019 23:14:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190924/4139b555/attachment.html>