[Asterisk-code-review] stasis_state: Create internal stasis_state_proxy object. (...asterisk[17])

Kevin Harwell asteriskteam at digium.com
Tue Sep 24 14:23:36 CDT 2019


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12911 )

Change subject: stasis_state: Create internal stasis_state_proxy object.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/12911/1/main/stasis_state.c 
File main/stasis_state.c:

https://gerrit.asterisk.org/#/c/12911/1/main/stasis_state.c@602 
PS1, Line 602: 			ao2_ref(state, +1);
> This reference and the matching unref in state_find_and_remove_eid ensure that the object will not f […]
If you want I think what you've written here would be a good comment in the code.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12911
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: I400e0db4b9afa3d5cb4ac7dad60907897e73f9a9
Gerrit-Change-Number: 12911
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 24 Sep 2019 19:23:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Corey Farrell <git at cfware.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190924/a58fe7cd/attachment.html>


More information about the asterisk-code-review mailing list