[Asterisk-code-review] channel/chan_pjsip: add dialplan function for music on hold (...asterisk[16])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12929 )

Change subject: channel/chan_pjsip: add dialplan function for music on hold
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/12929/1/channels/pjsip/dialplan_functions.c 
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/12929/1/channels/pjsip/dialplan_functions.c@85 
PS1, Line 85: 		Get or change the on hold behavior for a SIP call.
s/on hold/on-hold/


https://gerrit.asterisk.org/#/c/12929/1/channels/pjsip/dialplan_functions.c@92 
PS1, Line 92: 		<para>If Yes On-Hold Re-Invites are sent If No, music on hold is generated.</para>
"If <replaceable>yes</replaceable>, on-hold re-INVITEs are sent. If <replaceable>no</replaceable>, music on hold is generated."


https://gerrit.asterisk.org/#/c/12929/1/channels/pjsip/dialplan_functions.c@93 
PS1, Line 93: 		<para>This function can be used to overried the moh_passthrough configuration option</para>
s/overried/override/


https://gerrit.asterisk.org/#/c/12929/1/channels/pjsip/dialplan_functions.c@1465 
PS1, Line 1465: 	if (len < 3) {
              : 		ast_log(LOG_WARNING, "%s: buffer too small\n", cmd);
              : 		ast_channel_unlock(chan);
              : 		return -1;
              : 	}
Is this check really necessary? If so, do it before taking the channel lock.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12929
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Iebe905b2ad6dbaa87ab330267147180b05a3c3a8
Gerrit-Change-Number: 12929
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 24 Sep 2019 13:38:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190924/825367af/attachment-0001.html>