[Asterisk-code-review] feat: AudioSocket channel and application (...asterisk[master])

[Seán C. McCord]

Seán C. McCord has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11579 )

Change subject: feat: AudioSocket channel and application
......................................................................


Patch Set 14:

> Patch Set 13:
> 
> (18 comments)
> 
> > Patch Set 12: Code-Review-1
> > 
> > (1 comment)
> > 
> > Is UUID absolutely required?  Could you just use the unique channel id, whether auto-generated or provided in an ARI call?   If so, then chan_audiosocket could easily plug into the new externalMedia thing with encapsulation "audiosocket" and transport "tcp". with no other changes to your code.
> 
> Would it be sufficient to use something like UUIDv5, which creates a UUID from the SHA-1 hash of a namespace and name?  That could be deterministic so long as there is an agreed namespace UUID (arbitrary generated UUID for "Asterisk" perhaps?).
> 
> This would supply a means by which we could use the unique channel ID but still conform to the existing AudioSocket protocol specification.

I could even just internally convert the ID to a UUIDv5, though I would then need to expose a dialplan function like `CHANNEL(uuid)` so that the caller could easily obtain the deterministic UUID.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11579
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie866e6c4fa13178ec76f2a6971ad3590a3a588b5
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 14
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Sun, 22 Sep 2019 23:40:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190922/5247c66d/attachment.html>