[Asterisk-code-review] func_jitterbuffer: Add audio/video sync support. (...asterisk[17])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12870 )

Change subject: func_jitterbuffer: Add audio/video sync support.
......................................................................


Patch Set 2: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/12870/2/funcs/func_jitterbuffer.c 
File funcs/func_jitterbuffer.c:

https://gerrit.asterisk.org/#/c/12870/2/funcs/func_jitterbuffer.c@67 
PS2, Line 67: video
Instead of just "video", how about "sync_video"?


https://gerrit.asterisk.org/#/c/12870/2/include/asterisk/abstract_jb.h 
File include/asterisk/abstract_jb.h:

https://gerrit.asterisk.org/#/c/12870/2/include/asterisk/abstract_jb.h@48 
PS2, Line 48: AST_JB_VIDEO
AST_JB_SYNC_VIDEO ?


https://gerrit.asterisk.org/#/c/12870/2/main/abstract_jb.c 
File main/abstract_jb.c:

https://gerrit.asterisk.org/#/c/12870/2/main/abstract_jb.c@937 
PS2, Line 937: 9000
should this be 90000 instead of 9000?


https://gerrit.asterisk.org/#/c/12870/2/main/abstract_jb.c@939 
PS2, Line 939: 90000
Or should this be 9000 instead of 90000?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12870
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: I3fd75160426465e6d46bb2e198c07b9d314a4492
Gerrit-Change-Number: 12870
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 17 Sep 2019 12:28:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190917/1bcb41e9/attachment.html>