[Asterisk-code-review] res_pjsip_nat: Restore original contact for REGISTER responses (...asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12824 )

Change subject: res_pjsip_nat: Restore original contact for REGISTER responses
......................................................................


Patch Set 4:

> Patch Set 4:
> 
> > Patch Set 4:
> > 
> > One more issue.
> > I don't know why, but this patch is not working if the active contact record already exists in realtime table ps_contacts.
> > 
> > If contact exists in ps_contacts then debug only
> > Saving contact
> > got contact 
> > So when "got contact" the x-ast-orig-host not found and it's not saved into realtime table ps_contacts,
> > the uri field is 'sip:endpoint at endpoint-public-ip:endpoint-public-port'
> > 
> > If contact not  exists in ps_contacts then debug
> > Saving contact
> > got contact
> > Found orig host:
> > The x-ast-orig-host is found and it's saved into realtime table ps_contacts
> > the uri field is 'sip:endpoint at endpoint-public-ip:endpoint-public-port;x-ast-orig-host=endpoint-private-ip:endpoint-private-port'
> 
> 
> Could you, please, look at res_pjsip_registrar.c function register_aor_core
> starting with line 804.
> It seems if contact URI:PORT from request is found in sorcery then this sorcery's contact will be used in response (so we lost x-ast-orig-host)

I don't think so.  We get a copy of the existing contact object, which has the x-ast-orig-host parameter, the modify a few fields like expiration time, then put it back in the contacts container with the parameter preserved.  I just tested it and it works as expected.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Idc263ad2d2d7bd8faa047e5804d96a5fe1cd282e
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 16 Sep 2019 12:01:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190916/466cf884/attachment.html>