[Asterisk-code-review] channels: Allow updating variable value (...asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12744 )

Change subject: channels: Allow updating variable value
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

Minor nit about return value.

https://gerrit.asterisk.org/#/c/12744/6/include/asterisk/config.h 
File include/asterisk/config.h:

https://gerrit.asterisk.org/#/c/12744/6/include/asterisk/config.h@974 
PS6, Line 974:  * \retval -1 if no replacement occured
Code returns 1 not -1.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12744
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ie1897a96c82b8945e752733612ee963686f32839
Gerrit-Change-Number: 12744
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Guido Falsi <madpilot at freebsd.org>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 11 Sep 2019 23:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190911/a330c0b9/attachment-0001.html>