[Asterisk-code-review] res_pjsip_nat: Restore original contact for REGISTER responses (...asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12824 )

Change subject: res_pjsip_nat: Restore original contact for REGISTER responses
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/12824/3/res/res_pjsip_nat.c 
File res/res_pjsip_nat.c:

https://gerrit.asterisk.org/#/c/12824/3/res/res_pjsip_nat.c@157 
PS3, Line 157: uri = pjsip_uri_get_uri(contact_uri);
No, I told about uri, not contact->uri.
Before call save_orig_contact_host there is
pjsip_sip_uri *uri = pjsip_uri_get_uri(contact->uri);
This 'uri' can be passed to save_orig_contact_host, like
save_orig_contact_host(rdata, uri);

so it should be
static void save_orig_contact_host(pjsip_rx_data *rdata, pjsip_sip_uri  *uri)
and no need
uri = pjsip_uri_get_uri(contact_uri);



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Idc263ad2d2d7bd8faa047e5804d96a5fe1cd282e
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 19:43:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190910/0527212e/attachment.html>