[Asterisk-code-review] res_pjsip_nat: Restore original contact for REGISTER responses (...asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12824 )

Change subject: res_pjsip_nat: Restore original contact for REGISTER responses
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/12824/2/res/res_pjsip_nat.c 
File res/res_pjsip_nat.c:

https://gerrit.asterisk.org/#/c/12824/2/res/res_pjsip_nat.c@312 
PS2, Line 312: 		pjsip_sip_uri *contact_uri = pjsip_uri_get_uri(contact->uri);
> I believe this should be checked if it's a valid sip uri before proceeding. If not I think there is the possibility of a crash when de-referencing an attribute.

pjsip_message_filter checks the URIs before they get this far.  If any of the request, from, to or contact URIs aren't sip or sips, the request is rejected.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Idc263ad2d2d7bd8faa047e5804d96a5fe1cd282e
Gerrit-Change-Number: 12824
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 10 Sep 2019 11:01:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190910/06f2df84/attachment.html>