[Asterisk-code-review] chan_dahdi: set CHANNEL(hangupsource) when a PRI channel hangs up (...asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12846 )

Change subject: chan_dahdi: set CHANNEL(hangupsource) when a PRI channel hangs up
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/12846/2//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/#/c/12846/2//COMMIT_MSG@27 
PS2, Line 27: Patch Set 2: Thank you for code review. Code modified as suggested to
Please undo this addition to the commit message.  The commit message is to document why a change is done and to describe the fix.

Documenting this is not helpful in the commit message because it is referring to something outside of the patch.  The history of a patch is automatically documented in the Gerrit review.  Gerrit reviews allow you to *perfect* your patch before it is merged into the codebase.


https://gerrit.asterisk.org/#/c/12846/1/channels/sig_pri.c 
File channels/sig_pri.c:

https://gerrit.asterisk.org/#/c/12846/1/channels/sig_pri.c@1397 
PS1, Line 1397: 
              : 	sig_pri_lock_owner(pri, chanpos);
              : 	if (pri->pvts[chanpos]->owner) {
              : 		ast_queue_hangup(pri->pvts[chanpos]->owner);
              : 		ast_channel_unlock(pri->pvts[chanpos]->owner);
              : 	}
              : 
              : 	/* Tell the CDR this DAHDI channel hung up */
              : 	if(pri->pvts[chanpos]->owner) {
              : 		ast_set_hangupsource(pri->pvts[chanpos]->owner, ast_channel_name(pri->pvts[chanpos]->owner), 0);
              : 	}
> This patch creates a deadlock potential between the already held sig_pri_lock_private() and attempti […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12846
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I0f588a4bcf15ccd0648fd69830d1b801c3f21b7c
Gerrit-Change-Number: 12846
Gerrit-PatchSet: 2
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 05 Sep 2019 17:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190905/b49b0a20/attachment.html>