[Asterisk-code-review] chan_unistim: Fix clang warning: variable sized type not at end of a ... (...asterisk[13])

[Igor Goncharovsky]

Igor Goncharovsky has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12807 )

Change subject: chan_unistim: Fix clang warning: variable sized type not at end of a struct
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/12807/1/channels/chan_unistim.c 
File channels/chan_unistim.c:

https://gerrit.asterisk.org/#/c/12807/1/channels/chan_unistim.c@1021 
PS1, Line 1021: 		ast_log(LOG_WARNING, "recvmsg returned an error: %s\n", strerror(errno));
> If there's an error, I think you want to return. […]
Agree, error handling here and in code that use this function should be improved. I'll made update.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12807
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Ic1fd34c2c2bcc951da65bf62e3f7a8adff8351b1
Gerrit-Change-Number: 12807
Gerrit-PatchSet: 1
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Comment-Date: Wed, 04 Sep 2019 03:38:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190903/5742fadb/attachment.html>